Skip to content

Conversation

asherber
Copy link
Member

It would be better to merge this after #665, in case there are any changes needed here (and so that the repo actually has RTFNotes to display).

The modal dialog will display RTFNotes in a (readonly) text edit control, falling back to Notes. If neither one exists, then no dialog is shown. The caller can specify the dialog caption, height, and width; sensible defaults are provided.

@cv-on-hub Please see if this meets your needs as a replacement for the custom code you've got behind your ? buttons. Note that after the other PR is merged all scripts with Notes will automatically get RTFNotes during the build process.

@asherber asherber requested a review from rpatters1 January 31, 2024 03:00
@rpatters1
Copy link
Collaborator

One thing to be aware of about this function is that for RTF display it requires RGP Lua 0.68+. (And depending on which APIs you use, possible even 0.71, but I doubt you are using GetCharacterAtIndex, which will be replaced in 0.71 with a different API due to its lack of proper UTF-16 support.)

But then, multiline edit boxes only work on Mac. I assume that's what @cv-on-hub was using to show info before I added the text editor control. So any script that shows info in a multiline edit box must use FCCtrlTextEditor for cross platform compatibility and should therefore require 0.68 minimum.

@rpatters1
Copy link
Collaborator

Eventually, it may make sense to expand this window to include all the functionality and display of the JW Lua info dialog. (You access that from the Explorer tab.) That will save me the trouble of doing it in RGP Lua.

But we can leave that as a future enhancement.

@rpatters1 rpatters1 merged commit ba1fcf3 into finale-lua:master Jan 31, 2024
@asherber asherber deleted the notes branch February 12, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants