Fix broken user links

[andypols]

Describe the bug
The links to users in PushDetails and RepoDetails currently point to /dashboard/user/user-id, but the React Router expects them to be under /dashboard/admin/user/:id.

Expected behaviour
I can see the reasoning for keeping the list of users as an admin feature. However, since the admin routes can restricted to admin users via uiRouteAuth config, these links to user profiles don’t work for non-admin users — which feels wrong.

My inclination is to make /user and /user/:id non-admin routes, so that links to user profiles work universally.

Question
What do others think about this change?

[jescalada]

I originally refactored those routes to be admin-only since I thought it didn't make sense for anybody to see the list of users. Wondering if we should fix the links so that they work universally only for profile viewing?

This might require a deeper look from my side since there's probably other edge cases related to the uiRouteAuth and broken links...

[andypols]

@jescalada I think the simplest fix would be to keep /user (the user list) as an admin-only route, but make /user/:id (e.g. for viewing who can review a repo or who rejected a push) non-admin, since that’s normal usage.

[andypols]

I'm happy to submit a PR for this as I have already fixed it internally.

[jescalada]

@andypols I've been looking at this in more detail, and I think the core issue is that the admin route names are hardcoded, so they may not reflect the actual uiRouteAuth config value. I'll look into implementing a more robust fix which would perhaps add an /admin prefix to the actual adminOnly routes, and also use correct links on each component.

A quick PR to fix the links is much appreciated! 🙏🏼

[kriswest]

resolved via #1268