Skip to content

Conversation

@kriswest
Copy link
Contributor

resolves: #1185

SIimple PR that replaces the existing checks in parseAction with a simpler test based on the content-type headers which should be both correct (the previous check for a GET request was not - pulls were being misclassified as default actions) and simpler to comprehend.

@netlify
Copy link

netlify bot commented Oct 15, 2025

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 1312a6e
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/68f69a3fd4e6b30008b464d3

@github-actions github-actions bot added the fix label Oct 15, 2025
@codecov
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.46%. Comparing base (375bd13) to head (1312a6e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1249      +/-   ##
==========================================
+ Coverage   83.40%   83.46%   +0.05%     
==========================================
  Files          70       70              
  Lines        3007     3005       -2     
  Branches      501      499       -2     
==========================================
  Hits         2508     2508              
+ Misses        396      394       -2     
  Partials      103      103              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@JamieSlome JamieSlome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🍰

@JamieSlome JamieSlome enabled auto-merge October 20, 2025 20:23
@06kellyjac
Copy link
Contributor

@JamieSlome good to see you here 🚀 I hope you're doing well.
Would you be able to update your LFX EasyCLA setup? After merging in main it's blocked for merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pull requests missclassified as 'default' and request URLs not stored correctly

3 participants