-
Notifications
You must be signed in to change notification settings - Fork 147
fix: correct and simplify git push/pull request classification using content-type headers #1249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1249 +/- ##
==========================================
+ Coverage 83.40% 83.46% +0.05%
==========================================
Files 70 70
Lines 3007 3005 -2
Branches 501 499 -2
==========================================
Hits 2508 2508
+ Misses 396 394 -2
Partials 103 103 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🍰
|
@JamieSlome good to see you here 🚀 I hope you're doing well. |
resolves: #1185
SIimple PR that replaces the existing checks in parseAction with a simpler test based on the content-type headers which should be both correct (the previous check for a GET request was not - pulls were being misclassified as default actions) and simpler to comprehend.