Skip to content

Conversation

@andypols
Copy link
Contributor

@andypols andypols commented Oct 31, 2025

Summary

This PR adds a delete confirmation dialog to prevent accidental repository deletions.

Background

I unintentionally deleted a repository after clicking “Delete” while moving the mouse toward the “Code” button. To avoid similar mistakes, this PR introduces a confirmation step before deletion.

Fix

  • Adds a confirmation dialog when deleting a repository.
  • Requires the user to type (or paste) the repository name to confirm the action.
  • Follows the standard UI convention used for similar destructive actions.
CleanShot 2025-10-31 at 14 54 38@2x

The delete button is enabled when the correct repo name has been added.

CleanShot 2025-10-31 at 14 55 29@2x

Note

There’s a quirk where you can’t remove the default repository. Right after a repo is deleted, the handler restarts the proxy, and during that restart, proxyPreparations() runs again — which re-inserts every repo defined in proxy.config.json. If the repo you deleted is listed there, it’s immediately recreated, so the UI still shows it even after a refresh.

@netlify
Copy link

netlify bot commented Oct 31, 2025

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 573336a
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/69087c02b4f8e10008811925

@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.36%. Comparing base (a0e5bcc) to head (573336a).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1267   +/-   ##
=======================================
  Coverage   83.36%   83.36%           
=======================================
  Files          70       70           
  Lines        3005     3005           
  Branches      499      499           
=======================================
  Hits         2505     2505           
  Misses        397      397           
  Partials      103      103           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@andypols andypols requested a review from jescalada October 31, 2025 15:11
Copy link
Contributor

@jescalada jescalada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@andypols andypols closed this Nov 3, 2025
@andypols andypols deleted the add-delete-confirmation branch November 3, 2025 11:59
@andypols andypols restored the add-delete-confirmation branch November 3, 2025 12:44
@andypols andypols reopened this Nov 3, 2025
@jescalada jescalada merged commit 6dc22e9 into finos:main Nov 3, 2025
22 checks passed
@andypols andypols deleted the add-delete-confirmation branch November 3, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants