-
Notifications
You must be signed in to change notification settings - Fork 147
feat: introduce proper commit linting #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@temideewan - make sure to review and sign the EasyCLA 👍 This is a requirement before we can merge your PR... |
|
@temideewan, can you please merge in the latest remote changes from this repository, so we can get the vulnerability scan to run before we merge? |
|
Hi @JamieSlome |
|
@TheJuanAndOnly99, is there any reason the CVE checks aren't running on this PR? |
|
@JamieSlome Strange. Looking into it. Will get back to you as soon as I find something. |
|
@JamieSlome @temideewan The action is set to trigger only on "push". I've just sent a PR that would add the trigger on "pull_requests" as well. I'm not sure if it will make it run on this PR however. If it doesn't we may need to close it and re send it. |
|
@temideewan, are you able to close and re-open the PR? |
|
@JamieSlome @temideewan I don't think we need to close. I re ran the actions and the CVE scan is working + passing! |
|
Okay so it can be merged yeah? I'm really excited contributing to this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🍰
|
@temideewan - for some reason, the checks aren't running for me. Do you get a successful linting when you try to commit? |
|
Yes I do. |
|
Hi @JamieSlome |
feat: introduce proper commit linting
Closes #172