Skip to content

Conversation

@temideewan
Copy link
Contributor

@temideewan temideewan commented Jun 28, 2023

Closes #172

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 28, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@JamieSlome
Copy link
Member

@temideewan - make sure to review and sign the EasyCLA 👍 This is a requirement before we can merge your PR...

@JamieSlome
Copy link
Member

@temideewan, can you please merge in the latest remote changes from this repository, so we can get the vulnerability scan to run before we merge?

@temideewan
Copy link
Contributor Author

Hi @JamieSlome
I don't think anything has changed since when I created a fork of this repository

@JamieSlome
Copy link
Member

@TheJuanAndOnly99, is there any reason the CVE checks aren't running on this PR?

@TheJuanAndOnly99
Copy link
Member

@JamieSlome Strange. Looking into it. Will get back to you as soon as I find something.

@TheJuanAndOnly99
Copy link
Member

TheJuanAndOnly99 commented Jun 29, 2023

@JamieSlome @temideewan The action is set to trigger only on "push". I've just sent a PR that would add the trigger on "pull_requests" as well. I'm not sure if it will make it run on this PR however. If it doesn't we may need to close it and re send it.

@JamieSlome
Copy link
Member

@temideewan, are you able to close and re-open the PR?

@TheJuanAndOnly99
Copy link
Member

@JamieSlome @temideewan I don't think we need to close. I re ran the actions and the CVE scan is working + passing!

@temideewan
Copy link
Contributor Author

Okay so it can be merged yeah?

I'm really excited contributing to this.

Copy link
Member

@JamieSlome JamieSlome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🍰

@JamieSlome JamieSlome merged commit 919aae5 into finos:main Jun 29, 2023
@JamieSlome
Copy link
Member

@temideewan - for some reason, the checks aren't running for me. Do you get a successful linting when you try to commit?

@temideewan
Copy link
Contributor Author

Yes I do.
That's weird.
I'm following up on some threads about it here on GitHub though

@temideewan
Copy link
Contributor Author

Hi @JamieSlome
Since I can't replicate the issue on my end can you try any of the suggestions from this stack overflow thread?

coopernetes pushed a commit to coopernetes/git-proxy that referenced this pull request Oct 13, 2023
feat: introduce proper commit linting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add commit lint for commit history readability and cleanliness

3 participants