-
Notifications
You must be signed in to change notification settings - Fork 147
fix: commit lint bug #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: commit lint bug #182
Conversation
|
@temideewan - I'm just thinking, does it make sense to run this before every |
|
I see what you're saying. According to this blog we could switch |
|
@temideewan - thank you for doing the deep dive! Happy to go with the hook you think is most appropriate. Happy to proceed? I'll merge once you give me the green flag! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🍰
|
Yes there's an improvement I actually found to ensure we don't run it every single time, but I don't have access to my system right now so I can't test it out right now. |
Sorry, I didn't get back to you! I didn't have the time to get around to this over the weekend. Do you think we could give this another look? I have seen the usage of |
|
|
@temideewan - created #188 👍 |
fix: commit lint bug
Introduced a preinstall hook that ensures that husky is installed after a npm install.
Checks for proper commit messages should pass properly after this.