feat: add vite and remove react-scripts #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vaibssingh - let's remove |
|
Removed it myself, ready to merge! 🎉 |
coopernetes
pushed a commit
to coopernetes/git-proxy
that referenced
this pull request
Oct 13, 2023
feat: add vite and remove react-scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #192
Notes:
Removed react-scripts from package.json scripts. Left the eject script as it is. Let me know if it has to be removed.
Moved the index.html file from public to root folder. Updated the URLs and added index.js in script.
Added vite config file.
Verified that it works by running vite start.
Issues:
Currently on running the server, getting this warning in console:
(!) Could not auto-determine entry point from rollupOptions or html files and there are no explicit optimizeDeps.include patterns. Skipping dependency pre-bundling.Let me know if you would like to be fixed or we can leave it.
@JamieSlome