-
Notifications
You must be signed in to change notification settings - Fork 147
fix: rename files and use vite config in start script #199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@vaibssingh - awesome work 👍 I have started fixing up the |
|
For your reference: #200 |
|
@vaibssingh, a few conflicts for you there, sorry! The source of truth for what to keep comes from #200 😄 |
|
Alright @JamieSlome! I will merge this and test this. Hopefully this should resolve the issues 🤞🏽 |
|
Hey @JamieSlome , updated the PR with the latest code. Checked and it seems to be working. On UI, login screen opens up asking for credentials which I do not have so not able to test further than that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the one comment, and then we are ready for lift-off! 🚀
|
@JamieSlome Done! 👍🏽 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🍰
fix: rename files and use vite config in start script
Hey @JamieSlome , this should fix the start script and hopefully the build script too but I can't confirm either till we fix the issue with
react-router-dom.On starting the server and navigating to
localhost:3000I can see the API calls are being made and it tries to load the page till it encounters invalid imports from react-router-dom. So at least that's an improvement from yesterday's behaviour where it just gave 404 on opening.Let me know how you want me to proceed with this. I am happy to help you with the updates regarding react-router-dom.
Thanks for your help.
Fix #192