Skip to content

Conversation

@maoo
Copy link
Member

@maoo maoo commented Dec 21, 2023

Working on #365

@rgmz - would you mind reviewing these changes an provide feedback?

Thanks!

@netlify
Copy link

netlify bot commented Dec 21, 2023

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit d1e9352
🔍 Latest deploy log https://app.netlify.com/sites/endearing-brigadeiros-63f9d0/deploys/659bdb0d5fce7800087308b3

Copy link
Contributor

@rgmz rgmz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay. This looks great!

I have two suggestions that I think might read better, but they are just nitpicks.

maoo and others added 2 commits January 3, 2024 15:25
Co-authored-by: Richard Gomez <32133502+rgmz@users.noreply.github.com>
Co-authored-by: Richard Gomez <32133502+rgmz@users.noreply.github.com>
@maoo maoo marked this pull request as ready for review January 3, 2024 14:29
@maoo
Copy link
Member Author

maoo commented Jan 3, 2024

Thanks for the review @rgmz !

Time for a final review from @JamieSlome / @coopernetes and hit the Merge button 😉

@JamieSlome
Copy link
Member

Getting a diagram render issue:

Screenshot 2024-01-05 at 13 03 03

@JamieSlome JamieSlome changed the title Updating readme docs intro Improve README "About" description & Mermaid Diagram for Git Proxy Jan 5, 2024
@JamieSlome JamieSlome changed the title Improve README "About" description & Mermaid Diagram for Git Proxy Improve README "About" description & add Mermaid diagram Jan 5, 2024
@maoo
Copy link
Member Author

maoo commented Jan 5, 2024

@JamieSlome - fixed, try now plz.

Copy link
Contributor

@coopernetes coopernetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@JamieSlome JamieSlome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🍰

@JamieSlome JamieSlome merged commit 1c4f875 into main Jan 8, 2024
@JamieSlome JamieSlome deleted the readme-docs-intro branch January 8, 2024 11:24
Psingle20 pushed a commit to Psingle20/git-proxy that referenced this pull request Nov 27, 2024
Improve README "About" description & add Mermaid diagram
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants