Skip to content

fix: use codecov for test coverage reports #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 6, 2024
Merged

fix: use codecov for test coverage reports #429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1d03bc
fix: more permission into workflow
coopernetes Jan 30, 2024
fc86cf4
feat: test codecov
coopernetes Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 7 additions & 14 deletions .github/workflows/nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ on:
pull_request:
branches: [ main ]

permissions:
pull-requests: write

jobs:
build:

Expand All @@ -19,9 +22,6 @@ jobs:
node-version: [18.x]
mongodb-version: [4.4]

permissions:
pull-requests: write

steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4
with:
Expand Down Expand Up @@ -56,19 +56,12 @@ jobs:
echo "isNotEmpty=false" >> $GITHUB_OUTPUT
fi

- name: Install LCOV
- name: Upload test coverage report
if: ${{ steps.check-lcov-non-empty.outputs.isNotEmpty == 'true'}}
run: |
sudo apt-get update && sudo apt-get install --assume-yes lcov

- name: Report code coverage
if: ${{ steps.check-lcov-non-empty.outputs.isNotEmpty == 'true' }}
uses: zgosalvez/github-actions-report-lcov@v4
uses: codecov/codecov-action@v3.1.5
with:
coverage-files: ./coverage/lcov.info
github-token: ${{ secrets.GITHUB_TOKEN }}
update-comment: true

files: ./coverage/lcov.info
flags: unittests
# - name: Exit if coverage condition not met
# if: ${{ steps.test.outputs.exit_code }} != 0
# run: exit ${{ steps.test.outputs.exit_code }}
Expand Down
1 change: 1 addition & 0 deletions src/db/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ const nodemailer = require('nodemailer');
const generator = require('generate-password');
const passwordHash = require('password-hash');
const validator = require('email-validator');

const config = require('../config');

if (config.getDatabase().type === 'fs') {
Expand Down