Skip to content

Conversation

@maoo
Copy link
Member

@maoo maoo commented Feb 27, 2024

Note! we should probably add it to the website too!

@maoo maoo requested a review from JamieSlome February 27, 2024 15:28
@netlify
Copy link

netlify bot commented Feb 27, 2024

Deploy Preview for endearing-brigadeiros-63f9d0 ready!

Name Link
🔨 Latest commit 1a4ef9a
🔍 Latest deploy log https://app.netlify.com/sites/endearing-brigadeiros-63f9d0/deploys/65de5360e38b7a000809304b
😎 Deploy Preview https://deploy-preview-456--endearing-brigadeiros-63f9d0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.15%. Comparing base (bd95cf2) to head (1a4ef9a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #456   +/-   ##
=======================================
  Coverage   57.15%   57.15%           
=======================================
  Files          39       39           
  Lines        1055     1055           
=======================================
  Hits          603      603           
  Misses        452      452           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JamieSlome
Copy link
Member

@maoo - can you add it as an icon for now to the website in the nav bar at the top?

@maoo
Copy link
Member Author

maoo commented Feb 27, 2024

@JamieSlome - done; I used https://simpleicons.org/?q=slack and https://www.urlencoder.org/ ; for some reason, the white version (for dark mode) is the same as the black one; not sure if I'm missing something stupid here.

@JamieSlome
Copy link
Member

Seems like the deployment failed 🤔

To the side of that, just open up an SVG viewer. Does the two images appear as expected?

@maoo
Copy link
Member Author

maoo commented Feb 27, 2024

Seems like the deployment failed 🤔

I kicked it manually and it worked - https://deploy-preview-456--endearing-brigadeiros-63f9d0.netlify.app/

To the side of that, just open up an SVG viewer. Does the two images appear as expected?

Nope, the white version shows as black also on my local env; I'm missing something on how to use https://simpleicons.org/?q=slack download feature 😄

@JamieSlome JamieSlome changed the title add slack to readme Add Slack to README.md and documentation site Feb 27, 2024
@JamieSlome JamieSlome changed the title Add Slack to README.md and documentation site Add Slack to README.md and documentation site 🗨️ Feb 27, 2024
Copy link
Member

@JamieSlome JamieSlome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🍰

@JamieSlome JamieSlome merged commit fd0002a into main Feb 27, 2024
@JamieSlome JamieSlome deleted the add-slack-to-README branch February 27, 2024 21:31
Psingle20 pushed a commit to Psingle20/git-proxy that referenced this pull request Nov 27, 2024
Add Slack to `README.md` and documentation site 🗨️
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants