-
Notifications
You must be signed in to change notification settings - Fork 149
Add Slack to README.md and documentation site 🗨️
#456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #456 +/- ##
=======================================
Coverage 57.15% 57.15%
=======================================
Files 39 39
Lines 1055 1055
=======================================
Hits 603 603
Misses 452 452 ☔ View full report in Codecov by Sentry. |
|
@maoo - can you add it as an icon for now to the website in the nav bar at the top? |
|
@JamieSlome - done; I used https://simpleicons.org/?q=slack and https://www.urlencoder.org/ ; for some reason, the white version (for dark mode) is the same as the black one; not sure if I'm missing something stupid here. |
|
Seems like the deployment failed 🤔 To the side of that, just open up an SVG viewer. Does the two images appear as expected? |
I kicked it manually and it worked - https://deploy-preview-456--endearing-brigadeiros-63f9d0.netlify.app/
Nope, the white version shows as black also on my local env; I'm missing something on how to use https://simpleicons.org/?q=slack download feature 😄 |
README.md and documentation site
README.md and documentation siteREADME.md and documentation site 🗨️
JamieSlome
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🍰
Add Slack to `README.md` and documentation site 🗨️
Note! we should probably add it to the website too!