Skip to content

Conversation

@JamieSlome
Copy link
Member

@JamieSlome JamieSlome commented Mar 22, 2024

Closes #492

@vaibssingh - the fix was to move the CSRF exposure lower into app.use() call chain 👍

@JamieSlome JamieSlome added the bug Something isn't working label Mar 22, 2024
@JamieSlome JamieSlome self-assigned this Mar 22, 2024
@JamieSlome JamieSlome linked an issue Mar 22, 2024 that may be closed by this pull request
@netlify
Copy link

netlify bot commented Mar 22, 2024

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 9b9919e
🔍 Latest deploy log https://app.netlify.com/sites/endearing-brigadeiros-63f9d0/deploys/65fd80c53ed5300009980240

@socket-security
Copy link

socket-security bot commented Mar 22, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/eslint-parser@7.24.1 unsafe Transitive: environment, filesystem, shell +59 11.1 MB nicolo-ribaudo
npm/@babel/preset-react@7.24.1 Transitive: environment, filesystem, shell, unsafe +60 10.9 MB nicolo-ribaudo
npm/@commitlint/cli@19.2.1 Transitive: environment, eval, filesystem, shell, unsafe +105 42.3 MB escapedcat
npm/@commitlint/config-conventional@19.1.0 Transitive: filesystem +9 4.11 MB escapedcat
npm/@material-ui/core@4.12.4 environment Transitive: eval +34 15 MB eps1lon
npm/@material-ui/icons@4.11.3 None +6 11.9 MB eps1lon
npm/@seald-io/nedb@4.0.4 filesystem Transitive: environment, eval, network +27 1.76 MB seald
npm/@vitejs/plugin-react@4.2.1 Transitive: environment, filesystem, shell, unsafe +61 11 MB vitebot
npm/axios@1.6.8 network Transitive: environment, filesystem +8 2.22 MB jasonsaayman
npm/bit-mask@1.0.2 None +4 498 kB khrome
npm/body-parser@1.20.2 network Transitive: environment, eval, filesystem, unsafe +36 1.48 MB dougwilson
npm/chai-http@4.4.0 network Transitive: environment, eval, filesystem +44 6.44 MB keithamus
npm/chai@4.4.1 None +7 923 kB keithamus
npm/chartist@0.10.1 None 0 528 kB gionkunz
npm/concurrently@8.2.2 environment, filesystem Transitive: shell +12 11.8 MB gustavohenke
npm/cors@2.8.5 None +2 34.2 kB dougwilson
npm/diff2html@3.4.47 Transitive: environment, filesystem +6 9.05 MB rtfpessoa
npm/email-validator@2.0.4 None 0 12.1 kB manishsaraan
npm/eslint-config-google@0.14.0 None 0 24.8 kB philipwalton
npm/eslint-config-prettier@9.1.0 None 0 20.8 kB lydell
npm/eslint-config-standard@17.1.0 Transitive: environment, filesystem, unsafe +23 2.17 MB voxpelli
npm/eslint-plugin-import@2.29.1 filesystem, unsafe Transitive: environment, eval +90 5.6 MB ljharb
npm/eslint-plugin-node@11.1.0 filesystem Transitive: environment +16 1.5 MB mysticatea
npm/eslint-plugin-prettier@5.1.3 Transitive: environment +5 242 kB jounqin
npm/eslint-plugin-promise@6.1.1 None 0 67.1 kB eslint-community-bot
npm/eslint-plugin-standard@5.0.0 None 0 28.7 kB feross
npm/express-http-proxy@2.0.0 network Transitive: environment, eval, unsafe +13 930 kB monkpow
npm/express-rate-limit@7.2.0 network 0 112 kB nfriedly
npm/express-session@1.18.0 environment Transitive: eval +8 205 kB dougwilson
npm/express@4.19.1 environment, filesystem, network Transitive: eval, unsafe +55 1.57 MB wesleytodd
npm/generate-password@1.7.1 None 0 24.5 kB brendanashworth
npm/history@5.3.0 environment +2 395 kB mjackson
npm/husky@9.0.11 environment, filesystem, shell 0 3.61 kB typicode
npm/jsonschema@1.4.1 None 0 81.8 kB acubed
npm/load-plugin@6.0.2 environment Transitive: filesystem, shell +44 3.27 MB wooorm
npm/lusca@1.7.0 None +1 44.3 kB maxmil7
npm/mocha@10.3.0 environment, eval, filesystem +59 4.9 MB joshuakgoldberg
npm/moment@2.30.1 None 0 4.35 MB ichernev
npm/mongodb@5.9.2 environment, filesystem, network +16 9.8 MB dbx-node
npm/nodemailer@6.9.13 environment, filesystem, network, shell 0 503 kB andris
npm/nyc@15.1.0 environment, filesystem, unsafe Transitive: eval, shell +143 14.1 MB coreyfarrell
npm/passport-activedirectory@1.4.0 Transitive: environment, network +23 2.11 MB vbranden
npm/passport-local@1.0.0 None +1 13.2 kB jaredhanson
npm/passport@0.7.0 network +3 168 kB jaredhanson
npm/password-hash@1.2.2 None 0 14.2 kB davidwood
npm/prettier@3.2.5 environment, filesystem, unsafe 0 8.39 MB prettier-bot
npm/react-chartist@0.14.4 None 0 13.3 kB fraserxu
npm/react-dom@16.14.0 environment +4 3.15 MB gaearon
npm/react-html-parser@2.0.2 Transitive: environment, network +13 2.73 MB wrakky
npm/react-router-dom@6.22.3 environment Transitive: network +2 4.03 MB mjackson
npm/react@16.14.0 environment +3 296 kB gaearon
npm/uuid@9.0.1 None 0 123 kB ctavan
npm/vite@4.5.2 environment, eval, filesystem, network, shell, unsafe +31 218 MB vitebot
npm/yargs@17.7.2 environment, filesystem +15 634 kB oss-bot

🚮 Removed packages: npm/@babel/preset-env@7.23.9, npm/@babel/preset-react@7.23.3, npm/@babel/preset-typescript@7.23.3, npm/@babel/runtime@7.23.9, npm/@babel/template@7.23.9, npm/@babel/traverse@7.23.9, npm/@babel/types@7.23.9, npm/@docusaurus/core@3.1.1, npm/@docusaurus/preset-classic@3.1.1, npm/@hapi/hoek@9.3.0, npm/@jridgewell/trace-mapping@0.3.22, npm/@types/estree@1.0.5, npm/@types/istanbul-lib-coverage@2.0.6, npm/@types/json-schema@7.0.15, npm/@types/mdast@4.0.3, npm/@types/mime@1.3.5, npm/@types/react-router-config@5.0.11, npm/@types/react-router@5.1.20, npm/@types/unist@3.0.2, npm/address@1.2.2, npm/ajv-keywords@3.5.2, npm/algoliasearch@4.22.1, npm/autoprefixer@10.4.17, npm/caniuse-lite@1.0.30001580, npm/clean-css@5.3.3, npm/clsx@2.1.0, npm/core-js-compat@3.35.1, npm/css-what@6.1.0, npm/cssnano@5.1.15, npm/devlop@1.1.0, npm/domhandler@5.0.3, npm/domutils@3.1.0, npm/entities@4.5.0, npm/fast-glob@3.3.2, npm/get-stream@6.0.1, npm/globby@11.1.0, npm/hasown@2.0.2, npm/icss-utils@5.1.0, npm/ini@1.3.8, npm/is-docker@2.2.1, npm/kind-of@6.0.3, npm/merge2@1.4.1, npm/micromark-util-character@1.2.0, npm/micromark-util-symbol@1.1.0, npm/micromatch@4.0.5, npm/obuf@1.1.2, npm/postcss-value-parser@4.2.0, npm/react-dom@18.2.0, npm/react-fast-compare@3.2.2, npm/react-helmet-async@1.3.0, npm/react-router@5.3.4, npm/react@18.2.0, npm/safe-array-concat@1.1.2, npm/serialize-javascript@6.0.2, npm/set-function-name@2.0.2, npm/svgo@2.8.0, npm/tapable@2.2.1, npm/terser-webpack-plugin@5.3.10, npm/terser@5.27.0, npm/type-fest@2.19.0, npm/unified@11.0.4, npm/vfile@6.0.1, npm/webpack-sources@3.2.3, npm/which-typed-array@1.1.15, npm/yaml@1.10.2

View full report↗︎

@socket-security
Copy link

socket-security bot commented Mar 22, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Install scripts npm/esbuild@0.18.20

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/esbuild@0.18.20

@codecov
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.35%. Comparing base (f1be6bf) to head (9b9919e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #497      +/-   ##
==========================================
+ Coverage   57.27%   57.35%   +0.08%     
==========================================
  Files          39       39              
  Lines        1058     1060       +2     
==========================================
+ Hits          606      608       +2     
  Misses        452      452              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JamieSlome
Copy link
Member Author

@maoo - are we able to remove the Socket plugin from the project? It seems to be introducing a lot of noise 👍

@maoo
Copy link
Member

maoo commented Mar 22, 2024

@maoo - are we able to remove the Socket plugin from the project? It seems to be introducing a lot of noise 👍

Sure! You want the entire app to be removed, or just one of the branch validation checks?

@JamieSlome
Copy link
Member Author

@maoo - entire app for now 👍

@maoo
Copy link
Member

maoo commented Mar 22, 2024

@maoo - entire app for now 👍

done!

@JamieSlome JamieSlome closed this Mar 22, 2024
JamieSlome added a commit that referenced this pull request Mar 25, 2024
Re-introduce CSRF protection with Lusca ❤️ #497
Psingle20 pushed a commit to Psingle20/git-proxy that referenced this pull request Nov 27, 2024
Re-introduce CSRF protection with Lusca ❤️ finos#497
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error: CSRF token missing 🐛

3 participants