Skip to content

Conversation

@eddie-knight
Copy link
Contributor

@eddie-knight eddie-knight commented Apr 25, 2024

This will resolves #532.

  • Added CD workflow to make semver releases automatically based on PR title prefix
  • Added CI to validate PR title prefix
  • Added dependabot config to use PR title prefix

@netlify
Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 538a9a4
🔍 Latest deploy log https://app.netlify.com/sites/endearing-brigadeiros-63f9d0/deploys/663e18bd3dd7050008073fd4

@eddie-knight eddie-knight marked this pull request as draft April 25, 2024 00:26
@codecov
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.96%. Comparing base (6ddc713) to head (538a9a4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #534   +/-   ##
=======================================
  Coverage   56.96%   56.96%           
=======================================
  Files          46       46           
  Lines        1566     1566           
=======================================
  Hits          892      892           
  Misses        674      674           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maoo
Copy link
Member

maoo commented Apr 25, 2024

looks good to me @eddie-knight , thank you! Is it ok if you show us a test release during the next meeting on May 6th ? Feel free to also invite your colleagues at Sonatype, so we can get immediate feedback.

@JamieSlome - could you please have a look at this PR please?

TY!

Signed-off-by: Eddie Knight <knight@linux.com>
Signed-off-by: Eddie Knight <knight@linux.com>
@JamieSlome JamieSlome self-requested a review May 3, 2024 10:13
@JamieSlome
Copy link
Member

@eddie-knight - awesome PR, thank you 🎉

What do we need to do to close this off and merge?

@eddie-knight
Copy link
Contributor Author

What do we need to do to close this off and merge?

@JamieSlome It'll be important to note that once this is merged, all future PRs will have a new check running to validate that their title begins with one of the accepted terms.

Then, it'll be important that anyone merging PRs is aware of the implications of the title— a major, minor, or patch release will be made upon every PR merge following this one.

I'll take the PR out of draft mode and I can present it on Monday's call if you want, or you can merge it at your leisure.

@eddie-knight eddie-knight marked this pull request as ready for review May 3, 2024 13:24
Copy link
Member

@JamieSlome JamieSlome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🍰

@JamieSlome JamieSlome merged commit e6eec8e into finos:main May 10, 2024
Psingle20 pushed a commit to Psingle20/git-proxy that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Speed up release cycles ♻️

3 participants