-
Couldn't load subscription status.
- Fork 147
fix: ensure npm publish includes build directory #578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensure npm publish includes build directory #578
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #578 +/- ##
=======================================
Coverage 56.96% 56.96%
=======================================
Files 46 46
Lines 1566 1566
=======================================
Hits 892 892
Misses 674 674 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🍰
|
@tt-gideonaryeetey - have you signed the EasyCLA? 🤔 |
Yes |
I can check what is going on, but I'd need to know if you signed an Individual or Corporate CLA ; if the latter, EasyCLA requires a double confirmation for affiliation: one comes from the contributor, the other from the CLA Manager from your employer; I need to know who is your employer in order to validate which of the 2 confirmations is missing. |
I signed as Corporate CLA. My employer is turntabl. |
I see that you're approved using your @turntabl.io email address; this means that a) your git client must be configured accordingly and b) your Github account must list that email addresses under https://github.com/settings/emails I checked (a) via https://api.github.com/repos/finos/git-proxy/commits/d614e703215111095f26da7c7804582283858138 , so we're good. Unless (b) is what is missing, then the issue is that the affiliation confirmation from you (the contributor) is missing, and you need to access https://api.easycla.lfx.linuxfoundation.org/v2/repository-provider/github/sign/13399143/256513079/578/#/?version=2 in order to complete the process. Hope this helps! |
Thank you for the suggestions. I went through all the steps again to ensure I didn't miss anything. I pushed an update, and it seems to have passed the CLA check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🍰
…ored-by-npm fix: ensure npm publish includes build directory
No description provided.