Skip to content

Conversation

@tt-gideonaryeetey
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the fix label May 23, 2024
@netlify
Copy link

netlify bot commented May 23, 2024

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit ab0a7b2
🔍 Latest deploy log https://app.netlify.com/sites/endearing-brigadeiros-63f9d0/deploys/66573f366c1f3a0008a12dc9

@codecov
Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.96%. Comparing base (972eb4d) to head (ab0a7b2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #578   +/-   ##
=======================================
  Coverage   56.96%   56.96%           
=======================================
  Files          46       46           
  Lines        1566     1566           
=======================================
  Hits          892      892           
  Misses        674      674           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JamieSlome JamieSlome self-requested a review May 28, 2024 15:03
Copy link
Member

@JamieSlome JamieSlome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🍰

@JamieSlome
Copy link
Member

@tt-gideonaryeetey - have you signed the EasyCLA? 🤔

@tt-gideonaryeetey
Copy link
Contributor Author

@tt-gideonaryeetey - have you signed the EasyCLA? 🤔

Yes

@maoo
Copy link
Member

maoo commented May 29, 2024

@tt-gideonaryeetey - have you signed the EasyCLA? 🤔

Yes

I can check what is going on, but I'd need to know if you signed an Individual or Corporate CLA ; if the latter, EasyCLA requires a double confirmation for affiliation: one comes from the contributor, the other from the CLA Manager from your employer; I need to know who is your employer in order to validate which of the 2 confirmations is missing.

@tt-gideonaryeetey
Copy link
Contributor Author

@tt-gideonaryeetey - have you signed the EasyCLA? 🤔

Yes

I can check what is going on, but I'd need to know if you signed an Individual or Corporate CLA ; if the latter, EasyCLA requires a double confirmation for affiliation: one comes from the contributor, the other from the CLA Manager from your employer; I need to know who is your employer in order to validate which of the 2 confirmations is missing.

I signed as Corporate CLA. My employer is turntabl.

@maoo
Copy link
Member

maoo commented May 29, 2024

@tt-gideonaryeetey - have you signed the EasyCLA? 🤔

Yes

I can check what is going on, but I'd need to know if you signed an Individual or Corporate CLA ; if the latter, EasyCLA requires a double confirmation for affiliation: one comes from the contributor, the other from the CLA Manager from your employer; I need to know who is your employer in order to validate which of the 2 confirmations is missing.

I signed as Corporate CLA. My employer is turntabl.

I see that you're approved using your @turntabl.io email address; this means that a) your git client must be configured accordingly and b) your Github account must list that email addresses under https://github.com/settings/emails

I checked (a) via https://api.github.com/repos/finos/git-proxy/commits/d614e703215111095f26da7c7804582283858138 , so we're good. Unless (b) is what is missing, then the issue is that the affiliation confirmation from you (the contributor) is missing, and you need to access https://api.easycla.lfx.linuxfoundation.org/v2/repository-provider/github/sign/13399143/256513079/578/#/?version=2 in order to complete the process.

Hope this helps!

@tt-gideonaryeetey
Copy link
Contributor Author

@tt-gideonaryeetey - have you signed the EasyCLA? 🤔

Yes

I can check what is going on, but I'd need to know if you signed an Individual or Corporate CLA ; if the latter, EasyCLA requires a double confirmation for affiliation: one comes from the contributor, the other from the CLA Manager from your employer; I need to know who is your employer in order to validate which of the 2 confirmations is missing.

I signed as Corporate CLA. My employer is turntabl.

I see that you're approved using your @turntabl.io email address; this means that a) your git client must be configured accordingly and b) your Github account must list that email addresses under https://github.com/settings/emails

I checked (a) via https://api.github.com/repos/finos/git-proxy/commits/d614e703215111095f26da7c7804582283858138 , so we're good. Unless (b) is what is missing, then the issue is that the affiliation confirmation from you (the contributor) is missing, and you need to access https://api.easycla.lfx.linuxfoundation.org/v2/repository-provider/github/sign/13399143/256513079/578/#/?version=2 in order to complete the process.

Hope this helps!

Thank you for the suggestions. I went through all the steps again to ensure I didn't miss anything. I pushed an update, and it seems to have passed the CLA check.

Copy link
Member

@JamieSlome JamieSlome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🍰

@JamieSlome JamieSlome merged commit 5c791ee into finos:main May 29, 2024
Psingle20 pushed a commit to Psingle20/git-proxy that referenced this pull request Nov 27, 2024
…ored-by-npm

fix: ensure npm publish includes build directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants