Skip to content

Conversation

@coopernetes
Copy link
Contributor

Closes #655

@github-actions github-actions bot added the fix label Aug 7, 2024
@netlify
Copy link

netlify bot commented Aug 7, 2024

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 360e491
🔍 Latest deploy log https://app.netlify.com/sites/endearing-brigadeiros-63f9d0/deploys/66b447c8b2c1080009484f57

@codecov
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.39%. Comparing base (4a873e3) to head (360e491).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #678   +/-   ##
=======================================
  Coverage   57.39%   57.39%           
=======================================
  Files          46       46           
  Lines        1582     1582           
=======================================
  Hits          908      908           
  Misses        674      674           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JamieSlome JamieSlome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🍰

@JamieSlome
Copy link
Member

@coopernetes - do we want split up the CI to run in different container types or shall we track as a separate issue? Thanks for all the killer issues recently btw! ❤️

@coopernetes
Copy link
Contributor Author

@JamieSlome let's create a separate issue to add the different platforms to CI. Thanks!

@coopernetes coopernetes merged commit e10429b into finos:main Aug 8, 2024
@coopernetes coopernetes deleted the hotfix/esbuild-arm64 branch August 8, 2024 06:35
Psingle20 pushed a commit to Psingle20/git-proxy that referenced this pull request Nov 27, 2024
fix: resolve build error on arm64 machine
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build error on Mac non-x86 machine

2 participants