Skip to content

fix: Apply border-radius to search scrollbar #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 18, 2025
Merged

fix: Apply border-radius to search scrollbar #409

merged 2 commits into from
Oct 18, 2025

Conversation

@MoritzWeber0
Copy link
Member

@MoritzWeber0 MoritzWeber0 commented Oct 15, 2025 •
edited
Loading

Image

This PR fixes the missing border radius at the bottom right border.

@netlify
Copy link

netlify bot commented Oct 15, 2025 •
edited
Loading

✅ Deploy Preview for fipguide ready!

Name Link
🔨 Latest commit a825bd1
🔍 Latest deploy log https://app.netlify.com/projects/fipguide/deploys/68f354fe539e0b0008bb5652
😎 Deploy Preview https://deploy-preview-409--fipguide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Oct 15, 2025

Hi there! 👋

Thank you for your contribution to the FIP Guide! 🚀
We appreciate your effort in making rail staff travel information more accessible. 🚄

Checklist before merging:

  • Added a description to the Pull Request
  • Checked the License of new pictures (non-commercial use without attribution)
  • Modified content in English
  • Modified content in German
  • Modified content in French

@therobrob
Copy link
Member

therobrob commented Oct 15, 2025 •
edited
Loading

without an border-radius it looks really unsexy :(
didn't know, some browser don't support it correctly, so i've added the border.

@MoritzWeber0
Copy link
Member Author

MoritzWeber0 commented Oct 15, 2025

without an border-radius it looks really unsexy :( didn't know, some browser don't support it correctly, so i've added the border.

I'll try other approaches, maybe this will work: https://stackoverflow.com/questions/16676166/apply-border-radius-to-scrollbars-with-css

@MoritzWeber0 MoritzWeber0 force-pushed the fix/border-radius-search branch from b7165c9 to 0308ccb Compare October 15, 2025 16:57
@MoritzWeber0 MoritzWeber0 changed the title fix: Remove border-radius on search drawer fix: Apply border-radius to search scrollbar Oct 15, 2025
@MoritzWeber0
Copy link
Member Author

MoritzWeber0 commented Oct 15, 2025

Now it looks better :)

image

@therobrob
Copy link
Member

therobrob commented Oct 18, 2025

On windows there is an "scroll-down"-Button at the end of the scrollbar. Could it be cut of by the corner? I have no windows device so i can't check 🙃 I think it is okay to merge it now and check afterwards :) if there is an issue with the current implementation, we could add space with the borders under the scroll-area

@therobrob therobrob merged commit a866f15 into main Oct 18, 2025
7 checks passed
@therobrob therobrob deleted the fix/border-radius-search branch October 18, 2025 08:53
@therobrob
Copy link
Member

therobrob commented Oct 18, 2025

image

@MoritzWeber0 MoritzWeber0 mentioned this pull request Oct 18, 2025
Merged
therobrob pushed a commit that referenced this pull request Oct 18, 2025
@MoritzWeber0
fix: Move dynamic search height to correct class (#418)
cce7aad 
In #409, the definition of the max-height was moved to another class,
this PR reflects this for the mobile max-height, otherwise it doesn't
overwrite the value.

Also remove an unnecessary hard-coded positioning of the search drawer,
which led to gaps between drawer and search bar on some devices.
@MoritzWeber0 MoritzWeber0 mentioned this pull request Oct 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@therobrob therobrob therobrob approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MoritzWeber0 @therobrob