fix: scroll search into view on iOS-devices #417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there! 👋 Thank you for your contribution to the FIP Guide! 🚀 Checklist before merging:
|
✅ Deploy Preview for fipguide ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
MoritzWeber0
changed the title
MoritzWeber0
approved these changes
Oct 18, 2025
Member
MoritzWeber0
left a comment
MoritzWeber0
left a comment
There was a problem hiding this comment.
LGTM in general, I don't have an iOS device to test, but if it improves the visibility of the search bar, it makes sense. I wonder why this is necessary though, the search bar has an absolute positioning on content pages, do you know why scrolling is needed?
Member
Author
|
The search bar does not appear on iOS – the browser remains on its current position and doesn't scroll to the search bar. I think focussing the search-element is not sufficient, because it doesn't trigger scroll. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the search field on iOS devices was only visible in the viewport once you started typing. Now, clicking the magnifying glass scrolls directly to the search field.