feat: Anonymous Auth & Upgrade #2247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demolaf
commented
Oct 22, 2025
demolaf
commented
- Anonymous sign-in.
- Anonymous auto upgrade for account linking.
- e2e tests covering anonymous sign in and isAnonymousUpgradeEnabled configuration.
Lyokone
reviewed
Oct 22, 2025
Comment on lines
30
to
31
| // Error already handled via auth state flow in signInAnonymously() | ||
| // No additional action needed - ErrorRecoveryDialog will show automatically |
There was a problem hiding this comment.
Should we rethrow the error? Or remove the try catch?
Lyokone
reviewed
Oct 22, 2025
| * @suppress | ||
| */ | ||
| internal interface CredentialProvider { | ||
| // TODO(demolaf): make this internal |
Lyokone
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.