Skip to content

fix nullability annotations in authUI #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 3, 2016
Merged

fix nullability annotations in authUI #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa90c69
fix nullability annotations in authUI
morganchen12 Aug 2, 2016
717ea91
use prefix nullable annotation
morganchen12 Aug 3, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion FirebaseUI/Auth/AuthUI/Source/FIRAuthProviderUI.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ typedef void (^FIRAuthProviderSignInCompletionBlock)(FIRAuthCredential *_Nullabl
@param sourceApplication The application which tried opening the URL.
@return YES if your auth provider handled the URL. NO otherwise.
*/
- (BOOL)handleOpenURL:(NSURL *)URL sourceApplication:(NSString *)sourceApplication;
- (BOOL)handleOpenURL:(NSURL *)URL sourceApplication:(nullable NSString *)sourceApplication;

@end

Expand Down
6 changes: 2 additions & 4 deletions FirebaseUI/Auth/AuthUI/Source/FIRAuthUI.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,7 @@ typedef void (^FIRAuthUIResultCallback)(FIRUser *_Nullable user, NSError *_Nulla
@param user The signed in user if the sign in attempt was successful.
@param error The error that occured during sign in, if any.
*/
- (void)authUI:(FIRAuthUI *)authUI
didSignInWithUser:(nullable FIRUser *)user
error:(nullable NSError *)error;
- (void)authUI:(FIRAuthUI *)authUI didSignInWithUser:(nullable FIRUser *)user error:(nullable NSError *)error;

@optional

Expand Down Expand Up @@ -126,7 +124,7 @@ typedef void (^FIRAuthUIResultCallback)(FIRUser *_Nullable user, NSError *_Nulla
@return YES if Firebase Auth UI handled the URL. NO otherwise.
*/
- (BOOL)handleOpenURL:(NSURL *)URL
sourceApplication:(NSString *)sourceApplication;
sourceApplication:(nullable NSString *)sourceApplication;

/** @fn authViewController
@brief Returns an instance of the initial view controller of AuthUI.
Expand Down