DatabaseUI Tests: Road to green CI

[morganchen12]

The ultimate goal of this pull request is to make FirebaseUI more familiar for new contributors who are already used to the iOS OSS landscape. Ideally, any developer should be able to fork the repo and make changes with confidence that the unit tests will tell them if their changes have broken anything.

The first step of that is to have tests.

[ianbarber]

Deintegrate

[ulukaya]

pod-deintegrate doesn't delete those. You can simply delete those 3 build phases in xcode.

[ianbarber]

General CL looks good - definitely add a small changes/migration list, and any updates to docs.

One thing that occurs to me is that the fakes you made for the database primitives may be generally useful for developers. It might be worth considering cleaning them up and moving into a separate subproject so that people can use them in their own tests.

[morganchen12]

@ianbarber this PR now includes tests for basically all of databaseUI, which imo is good enough to merge and try to get CI up and running. Take a look at this when you can and I'll eventually put together a comprehensive changelist before merging.

Thanks!

[morganchen12]

Changelog:

FirebaseUI Changes

• FIRFacebookAuthUI scopes became readonly
• FIRFacebookAuthUI initializers no longer return optionals
• FIRGoogleAuthUI initializers no longer return optionals
• FIRGoogleAuthUI: Added designated initializer which takes an array of scopes along with client ID
• FIRGoogleAuthUI: Updated default scopes to use full G+ profile and email scope URLs
• FIRGoogleAuthUI: Made scopes property readonly
• FIRAuthUI: authUI method was renamed to defaultAuthUI
• FirebaseArray: delegate property is now nullable
• FirebaseArray: initWithQuery: parameter must be nonnull
• FirebaseArrayDelegate: methods renamed to take callee as first parameter, following platform conventions
  • childAdded:atIndex: renamed to array:didAddObject:atIndex:
  • childChanged:atIndex: renamed to array:didChangeObject:atIndex:
  • childRemoved:atIndex: renamed to array:didRemoveObject:atIndex:
  • childMoved:fromIndex:toIndex: renamed to array:didMoveObject:fromIndex:toIndex:
  • cancelledWithError: renamed to array:queryCancelledWithError:
• FirebaseCollectionViewDataSource: added null_resettable to cellClass and modelClass
• FirebaseCollectionViewDataSource: made populateCell readonly
• FirebaseTableViewDataSource: added null_resettable to modelClass
• FirebaseTableViewDataSource: made populateCell readonly
• FirebaseDataSource: made initWithArray: designated initializer

This only includes breaking and non-breaking API changes, not bug fixes.

[ianbarber]

This is a bit of an example of the concern from before - you're assigning to scopes, and skipping the "copy" property attribute. I think the right thing to do is to make the public property nonatomic, readonly, and in the anonymous category in the .m file override it to nonatomic, copy, readwrite.

[morganchen12]

Gonna merge for now, and then we can decide on the accessors in initializers style rule later.
As the codebase currently is, all of the auth code uses ivars in initializers and all of database doesn't. :((((((((((