Skip to content

Conversation

@russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Oct 10, 2025

Hey there! So you want to contribute to FirebaseUI? Before you file this pull request, follow these steps:

  • Update withGoogleSignIn(scopes scopes: [String]? = nil) to withGoogleSignIn(_ provider: GoogleProviderSwift? = nil).
  • Update withFacebookSignIn(scopes scopes: [String]? = nil) to withFacebookSignIn(_ provider: FacebookProviderSwift? = nil) so provider can be passed through.
  • Rename FacebookProviderAuthUI to FacebookProviderSwift in keeping with other providers as per API doc and gave it the provider functionality to createAuthCredential() and deleteUser() (needed as sensitive operation like delete user requires reauth).
  • FacebookProviderAuthUI now renders the button and holds FacebookProviderSwift for operations.
  • Rename GoogleProviderAuthUI to GoogleProviderSwift in keeping with other providers as per API doc and gave it the provider functionality to createAuthCredential() and deleteUser() (needed as sensitive operation like delete user requires reauth).
  • GoogleProviderAuthUI now renders the button and holds GoogleProviderSwift for operations.
  • Rename PhoneAuthProviderAuthUIProtocol to PhoneAuthProviderSwift in keeping with other providers as per API doc.
  • Renamed PhoneAuthProviderAuthUI to PhoneProviderSwift in keeping with other providers as per API doc.
  • PhoneAuthProviderAuthUI now renders the button and holds PhoneProviderSwift for operations.
  • remove registerModalView() API from auth service.
  • Phone auth modal usage is isolated to phone auth package.

@russellwheatley russellwheatley changed the title refactor: google provider refactor: google, facebook, phone providers Oct 10, 2025
@russellwheatley russellwheatley force-pushed the refactor-remaining-packages branch from 82b52c6 to c14ad31 Compare October 21, 2025 14:56
@russellwheatley russellwheatley changed the base branch from twitter-package to development October 21, 2025 15:09
@russellwheatley russellwheatley marked this pull request as ready for review October 22, 2025 12:54
Copy link

@demolaf demolaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@russellwheatley russellwheatley merged commit e838597 into development Oct 23, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants