feat: apple sign-in support #1278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russellwheatley
changed the title
russellwheatley
force-pushed
the
refactor-remaining-packages
branch
from
82b52c6 to
c14ad31
Compare
demolaf
reviewed
Oct 22, 2025
| } | ||
|
|
||
| func authenticate() async throws -> (ASAuthorizationAppleIDCredential, String) { | ||
| return try await withCheckedThrowingContinuation { continuation in |
There was a problem hiding this comment.
(ASAuthorizationAppleIDCredential, String) tuple is being returned but I don't see where.
There was a problem hiding this comment.
ah nevermind seen, interesting didn't think this was a way to go
russellwheatley
changed the base branch from
refactor-remaining-packages
to
development
russellwheatley
force-pushed
the
apple-provider
branch
from
a4e5835 to
ff554e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.