Skip to content

Conversation

@russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Oct 22, 2025

  • Create generic OAuth class that implements AuthProviderSwift
  • Create generic OAuth class that implements AuthProviderUI.
  • Create generic OAuth View button.
  • Create helper method for initialising Microsoft.
  • Create helper method for initialising Yahoo.
  • Create helper method for initialising Github.
  • Test appearance of Microsoft, Yahoo & Github.

Along with below noted, I've tweaked the API design:

  • created a helper method for registering OAuth providers.
  • Created a generic OAuth button that can be filled in with buttonIcon, buttonBackgroundColor, displayName and displayName so they don't have to implement their own button as was initially devised. See intialisers.

@russellwheatley russellwheatley changed the title feat: initial OAuth setup feat: OAuth package along with convenience methods for Yahoo, Microsoft and Github Oct 22, 2025
@russellwheatley russellwheatley marked this pull request as ready for review October 22, 2025 12:54
Copy link

@demolaf demolaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@russellwheatley russellwheatley changed the base branch from apple-provider to development October 24, 2025 11:33
@russellwheatley russellwheatley merged commit 4832ff7 into development Oct 24, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants