Skip to content

refactor: use AuthServiceError for all errors thrown #1281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 27, 2025
Merged

refactor: use AuthServiceError for all errors thrown #1281

merged 3 commits into from
Oct 27, 2025

Conversation

@russellwheatley
Copy link
Member

Description

  • Removed FacebookProviderError and GoogleProviderError in place of AuthServiceError.
  • Removed alert from FacebookSignInButton to use global errorAlert modal.
  • Refactored some of the errors so there is more uniformity across providers.

@russellwheatley russellwheatley marked this pull request as ready for review October 27, 2025 11:17
demolaf
demolaf approved these changes Oct 27, 2025
View reviewed changes
Copy link

@demolaf demolaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@russellwheatley russellwheatley merged commit cda7c4c into development Oct 27, 2025
5 of 7 checks passed
@russellwheatley russellwheatley deleted the unified-auth-service-error branch October 27, 2025 11:40
@russellwheatley russellwheatley mentioned this pull request Oct 28, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@demolaf demolaf demolaf approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@russellwheatley @demolaf