Skip to content

refactor: reauthentication made much simpler and now covers mfa enrollment and link accounts API #1290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 30, 2025
Merged

refactor: reauthentication made much simpler and now covers mfa enrollment and link accounts API #1290

merged 4 commits into from
Oct 30, 2025

Conversation

@russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Oct 30, 2025 •
edited
Loading

  • Ensure sensitive MFA operations reauth, as well as linkAccounts(). All sensitive operations should now be able to re-auth.
  • Use a much simpler method of reauthenticating so duplicate deleteUser() for each provider is removed.
  • Removed AccountService as it is no longer needed.
  • Operations that require reauth are now handled in the AuthService.

@russellwheatley russellwheatley changed the base branch from main to development October 30, 2025 12:01
@russellwheatley russellwheatley marked this pull request as ready for review October 30, 2025 12:21
@russellwheatley russellwheatley merged commit ff8ff47 into development Oct 30, 2025
3 of 4 checks passed
@russellwheatley russellwheatley deleted the reauth-mfa branch October 30, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@demolaf demolaf demolaf approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@russellwheatley @demolaf