Skip to content

fix: increase auth button width & fix compiler error from Facebook #1305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 10, 2025
Merged

fix: increase auth button width & fix compiler error from Facebook #1305

merged 9 commits into from
Nov 10, 2025

Conversation

@russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Nov 10, 2025 •
edited
Loading

  • Seems firebase-ios-sdk made the below objective-c only so moved to Swift API:
 let credential = OAuthProvider.credential(withProviderID: providerId,
                                                idToken: idToken.tokenString,
                                                rawNonce: nonce)
  • formatted Swift code.
  • fixes UI tests.
  • Report errors from MFA Views using reportError.
  • improved auth button width:
Simulator Screenshot - iPhone 17 Pro - 2025-11-10 at 09 31 33

@russellwheatley russellwheatley merged commit 4a52b73 into development Nov 10, 2025
4 checks passed
@russellwheatley russellwheatley deleted the small-improvements branch November 10, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@demolaf demolaf demolaf approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@russellwheatley @demolaf