refactor: made changes to API to reduce AuthService API surface area #1311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demolaf
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to minimise the size of the AuthService public API.
shouldHandleAnonymousUpgradeprivate.currentMFARequiredand put it on the Navigator routes to pass to MFAResolution.passwordPromptbut I don't think it is possible after trying a number of different ways. Sensitive operations require re-entering password. So I've created an email provider so that consumers can provide their own if they wish. This required making members on PasswordPromptCoordinator public, allowing withEmailSignIn to pass in a custom provider (following same pattern as other providers). I've also created a createReauthCredential() method on the email provider to make it obvious what passwordPrompt is used for.