-
Notifications
You must be signed in to change notification settings - Fork 488
refactor: add phone reauthentication and move reauth UI logic out of AuthService #1313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demolaf
approved these changes
Nov 19, 2025
demolaf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key Changes:
passwordPromptand EmailProvider from AuthService - Eliminated internal password prompting logic, delegating UI presentation to the view layer as it should be. Keep UI logic out of the AuthService.phoneReauthenticationRequirederror with phone number which kickstarts phone reauth.reauthenticate(context:)that automatically locates registered OAuth providers (Google, Apple, Facebook, Twitter, etc.), obtains fresh credentials, and completes reauthentication without manual credential management.reauthenticate(credential:)for when email/password create a credential for reauth.OAuth provider reauthentication
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2025-11-18.at.16.07.54.mov
Email provider reauthentication
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2025-11-18.at.16.28.24.mov
Phone provider reauthentication
Unfortunately, I hit the phone number sign-in limit so I've taken screenshots of the flow: