FCM Implementation (Part 1)

[hiranya911]

go/dotnet-fcm

Implements the following parts of the API:

FireabseMessaging
    SendAsync()
Message
Notification
AndroidConfig
ApnsConfig
WebpushConfig

Rest of the API will be fleshed out in subsequent PRs.

[bklimt]

LGTM, but with some minor feedback.

[bklimt]

I don't suppose there's any way to see that the message actually got all the parts it was supposed to?

It just seems kind of odd for an "integration test" to do a dryRun anyway.

[hiranya911]

dryRun mode does validate for message content (both locally and at the server). The operation will fail if the message is invalid.

[stewartmiles]

Yeah I agree with @bklimt this isn't great at the moment. Last time @alexames looked into testing this in the client SDKs end to end there wasn't really a way to do so without spinning up a XMPP server. If the REST request is formatted appropriately, I guess that's good enough for the mo'.

[hiranya911]

We do check the message content in our unit tests.

[bklimt]

You could use JsonConvert here as well.

[hiranya911]

This is actually needed for serialization (ok for deserialization). By default JsonConvert serializes null/zero values, which we don't want in the output.

[DenSmoke]

You can use this btw:

string json = JsonConvert.SerializeObject(message, Formatting.None,
            new JsonSerializerSettings { NullValueHandling = NullValueHandling.Ignore})```

[hiranya911]

Thanks @DenSmoke. NewtonsoftJsonSerializer from Google API client basically handles this. This prevents us from having to write the settings boilerplate in our code.

https://github.com/googleapis/google-api-dotnet-client/blob/bb7e9a2af7684ccd07e09ce0b52c2d00794795bb/Src/Support/Google.Apis.Core/Json/NewtonsoftJsonSerializer.cs#L141-L147

[bklimt]

Still LGTM