Add getTemplate functionality #799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahirumaramba
force-pushed
the
lm-rc-get-validate
branch
from
2eaa77a to
e719d9b
Compare
lahirumaramba
commented
Mar 3, 2020
hiranya911
suggested changes
Mar 3, 2020
hiranya911
suggested changes
Mar 4, 2020
| readonly conditions?: RemoteConfigCondition[]; | ||
| readonly parameters?: { [key: string]: RemoteConfigParameter }; | ||
| readonly version?: Version; //only undefined when there is no active template in the project | ||
| readonly eTag: string; |
There was a problem hiding this comment.
It seems the backend already sends this as etag. It's quite common to write this as etag. You will find many instances of that in that same page you've referenced. But it's almost never written as eTag in my experience.
hiranya911
approved these changes
Mar 5, 2020
| 'invalid-argument', | ||
| 'ETag header is not present in the server response.'); | ||
| } | ||
| const remoteConfigResponse: RemoteConfigResponse = { |
There was a problem hiding this comment.
Nit: You can collapse this into one statement.
return {
...
};
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getTemplate()RemoteConfigParameterValuetypeparametersinRemoteConfigTemplateto a hashmapgetTemplate