Skip to content

Add validate template functionality #806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 12, 2020
Merged

Add validate template functionality #806

merged 7 commits into from
Mar 12, 2020

Conversation

lahirumaramba
Copy link
Member

  • Add validateTemplate(...) operation
  • Add unit tests for validateTemplate

@lahirumaramba lahirumaramba requested a review from hiranya911 March 9, 2020 23:57
hiranya911
hiranya911 suggested changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good. Few comments on style and correctness, plus one suggestion on the API design.

hiranya911
hiranya911 suggested changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment on tests, and more explanations on how to turn RemoteConfigTemplate into a pure interface. I think we ought to do that change in a separate PR after the API amendments are properly reviewed.

hiranya911
hiranya911 approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM.

@lahirumaramba lahirumaramba merged commit 286ea45 into remote-config Mar 12, 2020
@lahirumaramba lahirumaramba deleted the lm_rc_validate_template branch March 12, 2020 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hiranya911 hiranya911 hiranya911 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lahirumaramba lahirumaramba

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lahirumaramba @hiranya911