Add publish template operation #814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lahirumaramba
commented
Mar 13, 2020
lahirumaramba
commented
- Implement publishTemplate()
- Add force publish support
- Add unit tests for publish template
lahirumaramba
commented
Mar 13, 2020
lahirumaramba
commented
Mar 13, 2020
hiranya911
suggested changes
Mar 16, 2020
lahirumaramba
commented
Mar 16, 2020
| .to.throw('ETag must be a non-empty string.'); | ||
| }); | ||
| }); | ||
|
|
There was a problem hiding this comment.
New test case for null, undefined, and empty etags.
hiranya911
approved these changes
Mar 16, 2020
hiranya911
approved these changes
Mar 17, 2020
| 'invalid-argument', | ||
| 'ETag must be a non-empty string.'); | ||
| } | ||
| const path = validateOnly ? 'remoteConfig?validate_only=true' : 'remoteConfig'; |
There was a problem hiding this comment.
Suggested change
| const path = validateOnly ? 'remoteConfig?validate_only=true' : 'remoteConfig'; | |
| let path = 'remoteConfig'; | |
| if (validateOnly) { | |
| path += '?validate_only=true'; | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.