Add support for Remote Config parameter groups #840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lahirumaramba
commented
Apr 6, 2020
lahirumaramba
commented
- Add support for RC Parameter Groups
- Add unit tests
- Add integration tests
hiranya911
approved these changes
Apr 6, 2020
|
@hiranya911 Thanks! Added more unit tests to cover cases where |
|
@egilmorez please review the docs for Remote Config Parameter Groups. Thank you!! |
lahirumaramba
commented
Apr 6, 2020
hiranya911
approved these changes
Apr 6, 2020
| }); | ||
| }); | ||
|
|
||
| it('should resolve with conditions:[] when no conditions present in the response', () => { |
There was a problem hiding this comment.
There's a lot of redundancy in these tests. As a future improvement, think about ways to clean it up a bit.
egilmorez
reviewed
Apr 8, 2020
src/index.d.ts
Outdated
|
|
||
| /** | ||
| * Map of parameter group names to their parameter group objects. | ||
| * A group's name is mutable but must be unique among groups in the config. |
There was a problem hiding this comment.
Not sure, but where we say "the config" here, do we mean the Remote Config template? Or maybe the RemoteConfig object, as you mention it in line 891?
There was a problem hiding this comment.
Good catch. It should be Remote Config template. Updated in both places. Thanks!
egilmorez
reviewed
Apr 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.