Skip to content

Conversation

@a-maurice
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Doxygen is having problems with the deleted constructors, so ignore them when running doxygen.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@a-maurice a-maurice added the skip-release-notes Skip release notes check label Jun 1, 2023
@a-maurice a-maurice changed the title Ignore the deleted constructors for doxygen Fix App and App Check headers for doxygen Jun 2, 2023
@a-maurice a-maurice requested a review from jonsimantov June 2, 2023 00:43
@a-maurice a-maurice merged commit 7ca8e40 into main Jun 2, 2023
@a-maurice a-maurice deleted the am-fix_app_check_doxygen branch June 2, 2023 17:08
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Jun 2, 2023
@github-actions
Copy link

github-actions bot commented Jun 2, 2023

❌  Integration test FAILED

Requested by @a-maurice on commit 7ca8e40
Last updated: Fri Jun 2 12:56 PDT 2023
View integration test log & download artifacts

Failures Configs
remote_config [BUILD] [ERROR] [MacOS] [x64] [openssl]

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Jun 2, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 2, 2023
@firebase firebase locked and limited conversation to collaborators Jul 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants