-
Notifications
You must be signed in to change notification settings - Fork 127
Add a GitHub warning to the iOS simulator logic #1371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sunmou99
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
echo works https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-a-warning-message
Not sure if print() works here. Should run some test or we have other examples in scripts.
Another nit, we could add check if available_versions:.
jonsimantov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(See comment about log message.)
The problem here is that this is the python script, so no access to echo. We use print in a couple of other scripts, so hopefully that does actually work. |
I did a quick test, and confirmed that using print generates a warning card on the action level, similar to echo. |
Integration test with FLAKINESS (succeeded after retry)Requested by @a-maurice on commit 1adbf0a
Add flaky tests to go/fpl-cpp-flake-tracker |
Description
Adds a GitHub warning to the iOS simulator logic, as a follow up to #1368
Testing
Type of Change
Place an
xthe applicable box:Notes
Release Notessection ofrelease_build_files/readme.md.