Skip to content

Release load_ad futures in flaky gma tests #1373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Release load_ad futures in flaky gma tests #1373

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 22 additions & 9 deletions gma/integration_test/src/integration_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1734,6 +1734,7 @@ TEST_F(FirebaseGmaTest, TestInterstitialAdLoadEmptyRequest) {
EXPECT_FALSE(result_ptr->response_info().response_id().empty());
EXPECT_FALSE(result_ptr->response_info().ToString().empty());

load_ad_future.Release();
delete interstitial;
}

Expand Down Expand Up @@ -1827,6 +1828,9 @@ TEST_F(FirebaseGmaTest, TestInterstitialAdErrorLoadInProgress) {
const firebase::gma::ResponseInfo response_info =
result_ptr->ad_error().response_info();
EXPECT_TRUE(response_info.adapter_responses().empty());

first_load_ad.Release();
second_load_ad.Release();
delete interstitial_ad;
}

Expand All @@ -1841,12 +1845,12 @@ TEST_F(FirebaseGmaTest, TestInterstitialAdErrorBadAdUnitId) {

// Load the interstitial ad.
firebase::gma::AdRequest request = GetAdRequest();
firebase::Future<firebase::gma::AdResult> load_ad =
firebase::Future<firebase::gma::AdResult> load_ad_future =
interstitial_ad->LoadAd(kBadAdUnit, request);
WaitForCompletion(load_ad, "LoadAd",
WaitForCompletion(load_ad_future, "LoadAd",
firebase::gma::kAdErrorCodeInvalidRequest);

const firebase::gma::AdResult* result_ptr = load_ad.result();
const firebase::gma::AdResult* result_ptr = load_ad_future.result();
ASSERT_NE(result_ptr, nullptr);
EXPECT_FALSE(result_ptr->is_successful());
EXPECT_EQ(result_ptr->ad_error().code(),
Expand All @@ -1856,6 +1860,8 @@ TEST_F(FirebaseGmaTest, TestInterstitialAdErrorBadAdUnitId) {
const firebase::gma::ResponseInfo response_info =
result_ptr->ad_error().response_info();
EXPECT_TRUE(response_info.adapter_responses().empty());

load_ad_future.Release();
delete interstitial_ad;
}

Expand Down Expand Up @@ -2011,6 +2017,9 @@ TEST_F(FirebaseGmaTest, TestRewardedAdErrorLoadInProgress) {
const firebase::gma::ResponseInfo response_info =
result_ptr->ad_error().response_info();
EXPECT_TRUE(response_info.adapter_responses().empty());

first_load_ad.Release();
second_load_ad.Release();
delete rewarded;
}

Expand All @@ -2023,12 +2032,12 @@ TEST_F(FirebaseGmaTest, TestRewardedAdErrorBadAdUnitId) {

// Load the rewarded ad.
firebase::gma::AdRequest request = GetAdRequest();
firebase::Future<firebase::gma::AdResult> load_ad =
firebase::Future<firebase::gma::AdResult> load_ad_future =
rewarded->LoadAd(kBadAdUnit, request);
WaitForCompletion(load_ad, "LoadAd",
WaitForCompletion(load_ad_future, "LoadAd",
firebase::gma::kAdErrorCodeInvalidRequest);

const firebase::gma::AdResult* result_ptr = load_ad.result();
const firebase::gma::AdResult* result_ptr = load_ad_future.result();
ASSERT_NE(result_ptr, nullptr);
EXPECT_FALSE(result_ptr->is_successful());
EXPECT_EQ(result_ptr->ad_error().code(),
Expand All @@ -2038,6 +2047,8 @@ TEST_F(FirebaseGmaTest, TestRewardedAdErrorBadAdUnitId) {
const firebase::gma::ResponseInfo response_info =
result_ptr->ad_error().response_info();
EXPECT_TRUE(response_info.adapter_responses().empty());

load_ad_future.Release();
delete rewarded;
}

Expand Down Expand Up @@ -2253,12 +2264,12 @@ TEST_F(FirebaseGmaTest, TestNativeAdErrorBadAdUnitId) {

// Load the native ad.
firebase::gma::AdRequest request = GetAdRequest();
firebase::Future<firebase::gma::AdResult> load_ad =
firebase::Future<firebase::gma::AdResult> load_ad_future =
native_ad->LoadAd(kBadAdUnit, request);
WaitForCompletion(load_ad, "LoadAd",
WaitForCompletion(load_ad_future, "LoadAd",
firebase::gma::kAdErrorCodeInvalidRequest);

const firebase::gma::AdResult* result_ptr = load_ad.result();
const firebase::gma::AdResult* result_ptr = load_ad_future.result();
ASSERT_NE(result_ptr, nullptr);
EXPECT_FALSE(result_ptr->is_successful());
EXPECT_EQ(result_ptr->ad_error().code(),
Expand All @@ -2268,6 +2279,8 @@ TEST_F(FirebaseGmaTest, TestNativeAdErrorBadAdUnitId) {
const firebase::gma::ResponseInfo response_info =
result_ptr->ad_error().response_info();
EXPECT_TRUE(response_info.adapter_responses().empty());

load_ad_future.Release();
delete native_ad;
}

Expand Down