-
Notifications
You must be signed in to change notification settings - Fork 127
ReleaseDebugConfigSupport #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ReleaseDebugConfigSupport #30
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
@stewartmiles could you merge it? |
|
@a-maurice could you merge it? |
|
Hi @crazyhappygame, sorry for the delay in getting back to you. Unfortunately, we have run into a couple roadblocks that have prevented us from setting up the repo to take in pull requests through GitHub (changes are being brought over from another repo, and it is currently one way, so this change would risk getting blown away). The change does look reasonable though, so if you are fine with it, I can replicate your change into that repo, and push it onto this. |
|
Ok |
|
@a-maurice @DellaBitta I checked the latest version 8.3 and those changes are still not there... |
Support multiple configuration
https://cmake.org/cmake/help/v3.16/variable/CMAKE_CONFIGURATION_TYPES.html#variable:CMAKE_CONFIGURATION_TYPES
https://cmake.org/cmake/help/v3.16/prop_tgt/MAP_IMPORTED_CONFIG_CONFIG.html