Firestore: Expand validation_test to cover other platforms #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
var-const
previously approved these changes
Mar 16, 2021
Also fix transactions on Android to throw immediately when C++ exceptions are enabled. While this doesn't have much of an effect on C++ users, this will make it possible for the Unity client to synchronously throw in these cases, which is expected in C#. Cloned from CL 355019084 by 'g4 patch'. Original change by mcg@mcg:fig-export-firestore-change-286-4f589224b545:4324:citc on 2021/02/01 13:52:36. PiperOrigin-RevId: 359824564
var-const
approved these changes
Mar 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix transactions on Android to throw immediately when C++
exceptions are enabled. While this doesn't have much of an effect on
C++ users, this will make it possible for the Unity client to
synchronously throw in these cases, which is expected in C#.
Cloned from CL 355019084 by 'g4 patch'.
Original change by mcg@mcg:fig-export-firestore-change-286-4f589224b545:4324:citc on 2021/02/01 13:52:36.
PiperOrigin-RevId: 359824564