Skip to content

Don't run the internal integration tests on the packaged SDK. #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 30, 2021
Merged

Don't run the internal integration tests on the packaged SDK. #350

merged 2 commits into from
Mar 30, 2021

Conversation

@jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Mar 30, 2021

No description provided.

@google-cla google-cla bot added the cla: yes label Mar 30, 2021
@jonsimantov jonsimantov added the tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). label Mar 30, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). labels Mar 30, 2021
@jonsimantov jonsimantov added the tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). label Mar 30, 2021
@github-actions github-actions bot removed the tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). label Mar 30, 2021
@github-actions
Copy link

github-actions bot commented Mar 30, 2021 •
edited
Loading

✅  Integration test succeeded!

Requested by @jonsimantov on commit 93b53b2
Last updated: Mon Mar 29 23:50:23 PDT 2021
View integration test results

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Mar 30, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Mar 30, 2021
@jonsimantov jonsimantov requested a review from DellaBitta March 30, 2021 18:13
@jonsimantov
Copy link
Contributor Author

jonsimantov commented Mar 30, 2021

This works: https://github.com/firebase/firebase-cpp-sdk/actions/runs/700332248

@jonsimantov jonsimantov merged commit 5f931bc into main Mar 30, 2021
@jonsimantov jonsimantov deleted the bugfix/dont-run-internal-test-on-packaged branch March 30, 2021 20:10
@firebase firebase locked and limited conversation to collaborators Apr 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DellaBitta DellaBitta DellaBitta approved these changes

Assignees

No one assigned

Labels

cla: yes tests: succeeded This PR's integration tests succeeded.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonsimantov @DellaBitta