Tie up the loose ends from moving Firestore's integration tests into integration_test_internal #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat the cached Java instance will be cleared. This changelist was previously ported in #329 but the integration testing component was lost in a merge.
…lled from Run() This changelist was previously ported in #330 but the integration testing component was lost in a merge.
This changelist was previously ported in #331 but the integration testing component was lost in a merge. As a benefit, this also fixes the broken promise_android_test.cc tests.
dconeybe
changed the title
jonsimantov
added
the
tests-requested: quick
github-actions
bot
added
tests: in-progress
Contributor
Author
|
It looks like the integration tests are failing to build due to |
firebase-workflow-trigger
bot
removed
the
tests: in-progress
Contributor
Author
|
Ahh, |
It was deleted in cl/329734038 in Sept 2020 but that deletion appears to not have gotten propagated to this GitHub repository).
dconeybe
added
tests-requested: quick
github-actions
bot
added
tests: in-progress
firebase-workflow-trigger
bot
removed
the
tests: in-progress
jonsimantov
suggested changes
Mar 31, 2021
Contributor
jonsimantov
left a comment
jonsimantov
left a comment
There was a problem hiding this comment.
Looks like two tests are still failing on Android:
[ FAILED ] TypeTest.TestCanReadAndWriteNullFields
[ FAILED ] TypeTest.TestCanReadAndWriteArrayFields
Could you (ideally) fix them or (alternately) skip them with the TODO?
…dcoded document name to prevent tests from interfering with each other
Contributor
Author
|
@jonsimantov: Those two failing tests (TestCanReadAndWriteNullFields and TestCanReadAndWriteArrayFields) appear to be transient failures. Looking at the code, each test case was using a hardcoded document, leaving room for tests to interfere with each other or even other unrelated parallel test runs interfering with each other. I suspect that is what happened here. To fix, I've change the test code in |
dconeybe
added
the
tests-requested: quick
github-actions
bot
added
tests: in-progress
dconeybe
added
tests: in-progress
firebase-workflow-trigger
bot
removed
the
tests: in-progress
dconeybe
changed the title
dconeybe
added
the
tests-requested: quick
github-actions
bot
added
tests: in-progress
firebase-workflow-trigger
bot
removed
the
tests: in-progress
dconeybe
added
tests-requested: quick
github-actions
bot
added
tests: in-progress
✅ Integration test succeeded!Requested by @dconeybe on commit 0684efc |
github-actions
bot
added
the
tests: succeeded
firebase-workflow-trigger
bot
removed
the
tests: in-progress
jonsimantov
approved these changes
Apr 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Firestore's integration tests were moved to the
integration_test_internalfolder, there were a few loose ends that needed to be tied. This PR ties them up.Changes in this PR include:
firestore/src/tests/android.firebase_firestore_settings_android_test.ccintointegration_test_internal, which was accidentally missed.Terminate()from~FirebaseFirestore()so that the cached Java instance will be cleared. #329, Port cl/361876089: JniRunnable: Fix a deadlock when Detach() is called from Run() #330, Port cl/362275804: Fix build error in promise_android_test.cc #331).promise_android_test.ccthat were fixed by re-applying Port cl/362275804: Fix build error in promise_android_test.cc #331.