Skip to content

Delete Firestore's Unity glue code, which now lives with the Unity C# code #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 8, 2021
Merged

Delete Firestore's Unity glue code, which now lives with the Unity C# code #352

merged 3 commits into from
Apr 8, 2021

Conversation

@dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Apr 1, 2021

No description provided.

@dconeybe dconeybe added the tests-requested: quick Trigger a quick set of integration tests. label Apr 1, 2021
@google-cla google-cla bot added the cla: yes label Apr 1, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Apr 1, 2021
@dconeybe dconeybe self-assigned this Apr 1, 2021
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Apr 1, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Apr 1, 2021
@sunmou99 sunmou99 added the tests-requested: quick Trigger a quick set of integration tests. label Apr 1, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Apr 1, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Apr 1, 2021
@sunmou99 sunmou99 added the tests-requested: quick Trigger a quick set of integration tests. label Apr 1, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Apr 1, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Apr 1, 2021
@dconeybe dconeybe added the tests-requested: quick Trigger a quick set of integration tests. label Apr 2, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Apr 2, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Apr 2, 2021
@dconeybe dconeybe added the tests-requested: quick Trigger a quick set of integration tests. label Apr 6, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Apr 6, 2021
@github-actions
Copy link

github-actions bot commented Apr 6, 2021 •
edited
Loading

✅  Integration test succeeded!

Requested by @dconeybe on commit 7eb2ec7
Last updated: Tue Apr 6 10:30:56 PDT 2021
View integration test results

@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Apr 6, 2021
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Apr 6, 2021
@dconeybe dconeybe requested a review from jonsimantov April 7, 2021 13:22
@dconeybe dconeybe enabled auto-merge (squash) April 7, 2021 16:37
@dconeybe dconeybe merged commit 431eccf into main Apr 8, 2021
@dconeybe dconeybe deleted the dconeybe/DeleteFirestoreUnityGlue branch April 8, 2021 19:01
@dconeybe dconeybe removed the request for review from jonsimantov April 8, 2021 19:02
@firebase firebase locked and limited conversation to collaborators May 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@a-maurice a-maurice a-maurice approved these changes

Assignees

@dconeybe dconeybe

Labels

api: firestore cla: yes tests: succeeded This PR's integration tests succeeded.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dconeybe @a-maurice @jonsimantov @sunmou99