Added build source to user agent string. #480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the library to determine whether the library was built on github or not.
alexames
force-pushed
the
feature/metric-tracking
branch
from
76f999b to
b4c9de7
Compare
DellaBitta
requested changes
Jun 18, 2021
scripts/gha/build_desktop.py
Outdated
| # workaround, absl doesn't build without tests enabled | ||
| cmd.append('-DBUILD_TESTING=off') | ||
| # When building from GitHub Actions, this should always be set. | ||
| cmd.append('-DFIREBASE_GITHUB_ACTION_BUILD=ON') |
Contributor
There was a problem hiding this comment.
This shouldn't be hard coded here. Our build scripts are run locally by the team and so local builds will be reported as GHA builds. Instead create a runtime flag on build_desktop.py that appends this -D command, and then alter .github/workflows/desltop.yml and .github/workflows/cpp-packaging.yml to add a --gha_build flag (or something) when the workflow invokes build_desktop.py
Contributor
Author
There was a problem hiding this comment.
I think I made the changes you wanted. Take a look and make sure I set it up right.
DellaBitta
requested changes
Jun 21, 2021
DellaBitta
approved these changes
Jun 21, 2021
github-actions
bot
added
the
tests: in-progress
❌ Integration test FAILEDRequested by @alexames on commit d682fd9
|
firebase-workflow-trigger
bot
removed
the
tests: in-progress
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the library to determine whether the library was built on
github or not.