- 
                Notifications
    
You must be signed in to change notification settings  - Fork 125
 
Feature/gha workflow base #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
      
          
      
      
            vimanyu
  
      
      
      commented
        Jun 22, 2020 
      
    
  
- "Windows only" github workflow for x64 Release desktop build using Visual Studio 2019
 - Separate workflow for "linux/mac/win" desktop builds (x64 Release)
 - using vcpkg as a cross-platform package manager for those dependencies that are not downloaded during cmake generation process
 - using github actions caching for packages installed using vcpkg (saves around 10 to 20 mins depending on platform)
 - ccache speed up for linux/mac builds (dramatically reduces build times 10 mins -> 2 mins on linux and 10 mins -> 5 mins on mac)
 
added vcpkg as a submodule added vcpkg response files for various platforms added requirements files to handle python dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions. Honestly, this is my first review of a build script like this and I would love for another one of the tagged reviewers to also make a pass at the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.