Skip to content

Conversation

@vimanyu
Copy link
Contributor

@vimanyu vimanyu commented Jun 22, 2020

  • "Windows only" github workflow for x64 Release desktop build using Visual Studio 2019
  • Separate workflow for "linux/mac/win" desktop builds (x64 Release)
  • using vcpkg as a cross-platform package manager for those dependencies that are not downloaded during cmake generation process
  • using github actions caching for packages installed using vcpkg (saves around 10 to 20 mins depending on platform)
  • ccache speed up for linux/mac builds (dramatically reduces build times 10 mins -> 2 mins on linux and 10 mins -> 5 mins on mac)

Copy link
Contributor

@DellaBitta DellaBitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions. Honestly, this is my first review of a build script like this and I would love for another one of the tagged reviewers to also make a pass at the PR.

Copy link
Contributor

@DellaBitta DellaBitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vimanyu vimanyu merged commit 17eba81 into dev Jun 29, 2020
@vimanyu vimanyu deleted the feature/gha-workflow-base branch June 29, 2020 19:49
@firebase firebase locked and limited conversation to collaborators Jul 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants