fix: fix pyproject.toml to include all packages.

[taeold]

Formatter is causing some churn, but the real diff is:

[tool.setuptools]
package-dir = { "" = "src" }
[tool.setuptools.packages.find]
where = ["src"]

to make sure that we include all subpackages (e.g. firebase_functions/private and firebase_functions/alerts) in the built package.

[gemini-code-assist]

Summary of Changes

Hello @taeold, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical packaging issue by updating the pyproject.toml configuration to ensure that all necessary subpackages are properly included during the build process. This change leverages setuptools's package discovery mechanism, which is essential for the correct distribution and functionality of the firebase_functions SDK. Additionally, it expands the declared Python version compatibility and includes minor formatting adjustments.

Highlights

• Package Inclusion Fix: Modified pyproject.toml to correctly include all subpackages (e.g., firebase_functions/private, firebase_functions/alerts) in the built Python package by switching from explicit package listing to setuptools.packages.find with where = ["src"].
• Python Version Support: Added classifiers for Python 3.12 and 3.13, indicating broader compatibility for the project.
• Formatting Updates: Applied general formatting changes across the pyproject.toml file, likely due to an automated formatter, which resulted in minor cosmetic adjustments to various sections.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request modifies the pyproject.toml file to ensure all subpackages are included in the built package. The changes involve updating the [tool.setuptools] section to use packages.find instead of explicitly listing packages, and some formatting adjustments. I have provided feedback focusing on code correctness and highlighting a potential issue with the ruff configuration.

[jhuleatt]

could we add a check to the build script to ensure all packages are there?

[taeold]

@jhuleatt that's good idea. I'll try to see if there is a way to do this without adding too much burden. For now, merging to help unblock FDC team for their integration.