Skip to content

Ensure cleanup is in type definition of module export. #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2018
Merged

Ensure cleanup is in type definition of module export. #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac26c03
Ensure cleanup is in type definition of module export.
Apr 21, 2018
b09d286
Rename FeatureList to FeaturesList
Apr 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/features.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import * as firestore from './providers/firestore';
import * as pubsub from './providers/pubsub';
import * as storage from './providers/storage';

export interface FeaturesList {
export interface LazyFeatures {
mockConfig: typeof mockConfig;
wrap: typeof wrap;
makeChange: typeof makeChange;
Expand All @@ -20,7 +20,7 @@ export interface FeaturesList {
storage: typeof storage;
}

export const features: FeaturesList = {
export const features: LazyFeatures = {
mockConfig,
wrap,
makeChange,
Expand All @@ -32,3 +32,7 @@ export const features: FeaturesList = {
pubsub,
storage,
};

export interface FeaturesList extends LazyFeatures {
cleanup;
}
2 changes: 1 addition & 1 deletion src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,5 +35,5 @@ export = (firebaseConfig?: AppOptions) => {
features = merge({}, features, {
cleanup: () => test.cleanup,
});
return features;
return features as FeaturesList;
};