Docs pass for v2.eventarc #1110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelgj
approved these changes
May 9, 2022
egilmorez
reviewed
May 9, 2022
Contributor
egilmorez
left a comment
egilmorez
left a comment
There was a problem hiding this comment.
Couple nits, thanks Joe!
src/v2/providers/eventarc.ts
Outdated
| } | ||
|
|
||
| /** | ||
| * A function that takes a CloudEvent. |
src/v2/providers/eventarc.ts
Outdated
| ): CloudFunction<CloudEvent<T>>; | ||
|
|
||
| /** Handles an Eventarc event. | ||
| * @param opts - Options to set on this Cloud Function |
Contributor
There was a problem hiding this comment.
I strongly prefer just "function," and think "Cloud Functions" -- the capped product -- should always be plural.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Docs review for v2 event arc - this one was looking pretty good but just needed some empty descriptions added.