Fix integration tests #1179
Merged
Fix integration tests #1179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we aren't allowed to run public functions on internal GCP project, we pass id tokens when making calls to callable/http functions.
colerogers
approved these changes
Jul 26, 2022
inlined
reviewed
Aug 8, 2022
| } | ||
| const url = `https://${REGION}-${firebaseConfig.projectId}.cloudfunctions.net/${name}`; | ||
| const client = await new GoogleAuth().getIdTokenClient( | ||
| '32555940559.apps.googleusercontent.com' |
Member
There was a problem hiding this comment.
What is this hard-coded project-specific string?
Member
There was a problem hiding this comment.
Doing some research, this is the CLI appID? Whatever it is, can't we assume that the default compute service account has invoker permissions and use the ADC?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One notable change made here is that we generate and include ID tokens in requests to http/callable functions since we aren't allowed to run public functions on internal GCP project