Update release script to support making release candidates #1261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colerogers
reviewed
Oct 14, 2022
scripts/publish.sh
Outdated
| echo "DEBUG: Running git status to show dirty files..." | ||
| git status | ||
| npm version $VERSION | ||
| if [[ $PRE_RELEASE == "" ]]; then |
Contributor
There was a problem hiding this comment.
Should we switch this if statement around since below we make the inverted check? Might be easier readability if they're all the same direction
colerogers
approved these changes
Oct 14, 2022
|
This is breaking deploys when upgrading. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new flag to allow us to create a release candidates with versions like
4.0.0-rc.0.Instructions added on go/publish-via-cloud-build.