Fix lint errors in /spec files at the top level #468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thechenky
changed the title
kevinajian
approved these changes
Jun 13, 2019
thechenky
added a commit
that referenced
this pull request
Jun 14, 2019
* adding lint command and modifying lint options * one additional format fix * order deps in package.json, remove unnecessary [] from tslint * Lint spec/* files (#468) * adding lint command and modifying lint options * one additional format fix * order deps in package.json, remove unnecessary [] from tslint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes lint errors for all top level files in the
specdirectory.Testing
With the linter set up like in #467:
npm run lint | grep <filename>should not return any warnings.For example:
npm run lint | grep apps.spec.ts.