Remove delay from integration tests and remove parallelization #480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We no longer need to wait after function deployment for the changes to propagate, since that bug was fixed on the backend, so I removed the 50 second delay between deployment and running tests. Internal bug reference: 74138171.
Additionally, since that delay was the slowest part of the integration tests and it was no longer needed, I removed the parallelization of running Node 8 and Node 10 tests on different projects and simplified the code. The slowest part now is the deployment of functions, which was still happening serially.
Testing
Run integration tests: